Cmake support on windows, update clang-format #1953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Renderer
External (3rd party)
Xottab-DUTY
reviewed
Sep 23, 2025
yohjimane
force-pushed
the
yohji/feat/cmake-windows
branch
from
908ab63 to
fe42ac5
Compare
yohjimane
force-pushed
the
yohji/feat/cmake-windows
branch
from
c03a8b2 to
e5a7d85
Compare
CMake supports that and it should be safe for other platforms (would be ignored)
Optimized xrNetServer and xr_3da
Xottab-DUTY
force-pushed
the
yohji/feat/cmake-windows
branch
3 times, most recently
from
e86a646 to
ef49455
Compare
Xottab-DUTY
force-pushed
the
yohji/feat/cmake-windows
branch
2 times, most recently
from
324f4ef to
e35d094
Compare
Xottab-DUTY
force-pushed
the
yohji/feat/cmake-windows
branch
from
e35d094 to
cc51a8e
Compare
Xottab-DUTY
force-pushed
the
yohji/feat/cmake-windows
branch
from
bd8fe61 to
d3e71b6
Compare
Also, CMAKE_GENERATOR_PLATFORM checking and unsetting code should go into XRay.Configurations.cmake. I just deleted it as I believe that CMAKE_GENERATOR_PLATFORM should not be specified for unsupported generators in the first place. Please, correct me if I'm wrong.
Xottab-DUTY
force-pushed
the
dev
branch
2 times, most recently
from
e38d9d8 to
94d0261
Compare
Xottab-DUTY
force-pushed
the
yohji/feat/cmake-windows
branch
from
9d56d52 to
e88da5a
Compare
Xottab-DUTY
force-pushed
the
yohji/feat/cmake-windows
branch
from
e88da5a to
51e50ca
Compare
Xottab-DUTY
force-pushed
the
yohji/feat/cmake-windows
branch
from
51e50ca to
8527ca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully building on win11
tested with this command:
cmake -S . -B build/vs2022 -G "Visual Studio 17 2022" -A x64 -DCMAKE_BUILD_TYPE=RelWithDebInfothen
cmake --build build/vs2022 --config MixedOR if you prefer to use visual studio:
open the build/vs2022/OpenXray.sln and build desired configuration